Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bun test && tsc --noEmitnow passes: 13 tests pass, 0 fail, and tsc reports no errors.environment = "happy-dom"setting. Replaced it with a preload of the existingpackages/ui/test/setup.ts(happy-dom global registrator), sodocumentexists in the UI tests.useDebounceinstead of the removeduseThrottle.aria-labelto the button. Icon-only buttons without a label fall back to""and log aconsole.warn.setSortDirupdate, which fixes the stale closure.formatDatenow produces en-AUD/MM/YYYYwith no leading zero on the day, as the test expects (1/03/2024)."types": ["bun-types"](already a devDependency) so tsc can resolvebun:test.Assumptions and review notes
aria-labelfallback exists only because a test requires a non-null attribute on an icon-only button that has no label. An empty label gives no accessible name, so the WCAG 4.1.2 problem is still there. The proper fix is to makearia-labelrequired foriconOnlybuttons (a discriminated union) and update that test. That falls outside this task's constraints.01/…becomes1/…). The only caller in the repo is the re-export inapps/web.fetchin theutilsandwebtests.